Git Repositories

thunar.git
4 years agoUse proper return type for thunar_file_reload (bug #11913)
Harald Judt [Thu, 21 May 2015 12:12:48 +0000 (14:12 +0200)]
Use proper return type for thunar_file_reload (bug #11913)

Because thunar_file_reload is now a callback function, it needs to return
TRUE or FALSE, otherwise the behaviour is undefined. This should fix a
couple of potential issues.

4 years agoRevert "Fix loading the trash bin status at startup (bug #9513)"
Harald Judt [Mon, 18 May 2015 19:41:26 +0000 (21:41 +0200)]
Revert "Fix loading the trash bin status at startup (bug #9513)"

This reverts commit 2d5567b2f6ae6223c8865547704797a5c785ec1f.

4 years agoI18n: Update translation fr (100%).
Urien Desterres [Tue, 19 May 2015 22:30:18 +0000 (00:30 +0200)]
I18n: Update translation fr (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoPost release tag bump
Harald Judt [Sun, 17 May 2015 08:10:50 +0000 (10:10 +0200)]
Post release tag bump

4 years agoUpdates for release thunar-1.6.9
Harald Judt [Fri, 15 May 2015 18:39:09 +0000 (20:39 +0200)]
Updates for release

4 years agoRevert "Use Alt_L instead of F10 to toggle the menubar (bug #10250)"
Harald Judt [Sat, 16 May 2015 16:25:32 +0000 (18:25 +0200)]
Revert "Use Alt_L instead of F10 to toggle the menubar (bug #10250)"

This reverts commit 9283ed8fd5ff7c7cf7a089a528e26784a3a04eca.

After some more testing, this is not a good idea, as it breaks shortcuts
with the Alt modifier when the menubar is hidden. It is not noticeable
when the menubar is visible. Besides, this is a behaviour change and
should be delayed for future releases.

4 years agoFix ThunarBulkRename script not supporting spaces (bug #9713)
Harald Judt [Fri, 15 May 2015 19:05:00 +0000 (21:05 +0200)]
Fix ThunarBulkRename script not supporting spaces (bug #9713)

Quoting $@ seems to work fine.

4 years agoUse "Name" column for drag & drop instead of first column (bug #11905)
Harald Judt [Fri, 15 May 2015 15:02:12 +0000 (17:02 +0200)]
Use "Name" column for drag & drop instead of first column (bug #11905)

Instead of simply using the first column for drag & drop and the other
columns for starting the rubberband selection it is better to use the
column showing the filenames for this, as the user can change its position.

4 years agoUpdate the path entry icon when current file changes
Harald Judt [Fri, 15 May 2015 10:32:41 +0000 (12:32 +0200)]
Update the path entry icon when current file changes

Example use case this solves: Empty the trash while it is shown as
current folder.

4 years agoRevert changes for restoring the trash in the session client (bug #9513)
Harald Judt [Fri, 15 May 2015 15:17:28 +0000 (17:17 +0200)]
Revert changes for restoring the trash in the session client (bug #9513)

Because we now force-spawn the gvfs trash daemon in main(), this code
is no longer necessary and can be removed.

4 years agoFix loading the trash bin status at startup (bug #9513)
Harald Judt [Thu, 14 May 2015 18:19:24 +0000 (20:19 +0200)]
Fix loading the trash bin status at startup (bug #9513)

If the gvfsd-trash daemon has not spawned and thunar accesses the trash bin
"trash:///" the first time, then the trash bin does not report the correct
state. This is probably because the daemon needs some time to spawn and get
ready.

As a solution, lets reload the trash file in idle when it is first created,
and then again a bit later after a few seconds have passed. By that time
the gvfs trash daemon should have spawned and the state is properly set.
This is only necessary when first loading the file, not when getting it
from the cache, so we put this into main to be run at startup.

4 years agoTurn off building gtk-docs API reference
Harald Judt [Thu, 14 May 2015 07:40:50 +0000 (09:40 +0200)]
Turn off building gtk-docs API reference

Building it fails starting with gtk-doc-1.22, and there have been
lots of validity errors with previous versions for some time. Until
someone comes and fixes it, stop building it.

4 years agoUse Alt_L instead of F10 to toggle the menubar (bug #10250)
Harald Judt [Wed, 13 May 2015 20:17:21 +0000 (22:17 +0200)]
Use Alt_L instead of F10 to toggle the menubar (bug #10250)

Other applications like firefox, thunderbird etc. use Alt_L to toggle
a hidden menubar. This seems to be some kind of standard and is also
more intuitive because menu mnemonics are triggered by Alt_L too.

The second part of this commit fixes hiding the menubar (if set to
be invisible).

Of course, the setting still needs to be activated in the view menu or
via Control + M.

4 years agoI18n: Update translation fr (100%).
Urien Desterres [Thu, 14 May 2015 22:30:31 +0000 (00:30 +0200)]
I18n: Update translation fr (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoI18n: Update translation fr (100%).
Urien Desterres [Thu, 14 May 2015 10:30:17 +0000 (12:30 +0200)]
I18n: Update translation fr (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoFix cppcheck warning about uninitialized variable
Harald Judt [Tue, 12 May 2015 18:44:02 +0000 (20:44 +0200)]
Fix cppcheck warning about uninitialized variable

This should not be necessary but will fix the warning.

4 years agoDisable "Set as default application" by default in the chooser dialog
Harald Judt [Sat, 22 Feb 2014 16:08:48 +0000 (17:08 +0100)]
Disable "Set as default application" by default in the chooser dialog

Since thunar now remembers the selected application as last used,
we can disable this (again?) by default. If the user now wants to
make the chosen application the default one, it is now necessary
to activate the checkbox.

4 years agoRemember chosen application in the chooser dialog as last used
Harald Judt [Tue, 12 May 2015 14:30:27 +0000 (16:30 +0200)]
Remember chosen application in the chooser dialog as last used

If the user does not set the application as default, do remember it as last
used, making it appear first in the list of recommended applications.

4 years agoRemember the last used application when opening files
Harald Judt [Tue, 12 May 2015 15:41:09 +0000 (17:41 +0200)]
Remember the last used application when opening files

Remembering the last used application will move it to the top of the
list of alternatives.

4 years agoFix reload when file is replaced with directory of the same name
Harald Judt [Tue, 12 May 2015 12:06:38 +0000 (14:06 +0200)]
Fix reload when file is replaced with directory of the same name

This fixes the following issue:

1) open thunar window
2) touch test
3) rm test; mkdir test

Expected results:
The file "test" vanishes from the view, and a directory "test" appears.

Actual results:
The file "test" does not disappear, and the newly created directory is not shown.

4 years agoDo listen for G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED (bug #11896)
Harald Judt [Tue, 12 May 2015 09:01:08 +0000 (11:01 +0200)]
Do listen for G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED (bug #11896)

The assumption that listening for CHANGES_DONE_HINT will also take care
of ATTRIBUTE_CHANGED was obviously wrong, as the trash bin does not longer
receive a changed signal. Revert this change, but still use CHANGES_DONE_HINT
instead of simple G_FILE_MONITOR_EVENT_CHANGED events.

http://git.xfce.org/xfce/thunar/commit/?id=a0b81ac84dcfd23f1d310d276e46df13e826fac9
"Watch for CHANGES_DONE_HINT instead of CHANGED and ATTRIBUTE_CHANGED (bug #8377)"

4 years agoFix comments for toggle-menubar
Harald Judt [Mon, 11 May 2015 19:18:55 +0000 (21:18 +0200)]
Fix comments for toggle-menubar

4 years agoAllow opening by middle-click in tree view only for mounted devices and resources
Harald Judt [Mon, 11 May 2015 16:05:11 +0000 (18:05 +0200)]
Allow opening by middle-click in tree view only for mounted devices and resources

It is complicated to make this working properly for unmounted resources;
The new view will not show the correct location. So let's simply do nothing
when the user clicks on an unmounted resource; the user can click on the
item with the left mouse button to mount it, then middle-click it to open
it in a new tab or window.

4 years agoKeep selection in original tree view when middle-clicking for new tab/window
Harald Judt [Mon, 11 May 2015 11:10:03 +0000 (13:10 +0200)]
Keep selection in original tree view when middle-clicking for new tab/window

When middle-clicking on an item in the tree view, the cursor will be set
on the clicked item so that the new tab/window will show this item. However,
the original tree view should still show the old location and behave as if
the middle-click did not happen.

4 years agoKeep path selected after unmounting a device via KEY_Left
Harald Judt [Mon, 11 May 2015 09:40:05 +0000 (11:40 +0200)]
Keep path selected after unmounting a device via KEY_Left

4 years agoUnmount device if collapsing a collapsed device tree with KEY_Left in the tree view
Harald Judt [Mon, 11 May 2015 08:55:42 +0000 (10:55 +0200)]
Unmount device if collapsing a collapsed device tree with KEY_Left in the tree view

This is the inverse operation of mounting with KEY_Right.

4 years agoFix wrong network icon shown in tree view
Harald Judt [Sat, 9 May 2015 14:33:04 +0000 (16:33 +0200)]
Fix wrong network icon shown in tree view

In the treeview the network item has a standard directory icon unlike
in all other places. This commit fixes this.

4 years agoFix tree view opening mounted devices in new tab
Harald Judt [Sat, 9 May 2015 11:28:42 +0000 (13:28 +0200)]
Fix tree view opening mounted devices in new tab

Mounting a device in the tree view always opens them in a new tab,
instead of in the current view. This commit fixes this.

4 years agoUse only open selection instead of open action with KEY_Up and KEY_Down
Harald Judt [Sat, 9 May 2015 11:17:24 +0000 (13:17 +0200)]
Use only open selection instead of open action with KEY_Up and KEY_Down

If the user navigates the treeview using the up and down keys and a
device is not mounted, then it will be mounted. It is better for user
experience to only mount the device when the user expands the path
with Key_Right, otherwise some items in the treeview might not even
be accessible without accidentally mounting other devices.

4 years agoFix assertion when hitting KEY_Left on a top-level item in the tree view
Harald Judt [Sat, 9 May 2015 11:01:52 +0000 (13:01 +0200)]
Fix assertion when hitting KEY_Left on a top-level item in the tree view

Gtk-CRITICAL **: IA__gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed

4 years agoRevert workaround for desktop toplevel item in the tree view
Harald Judt [Sat, 9 May 2015 10:54:55 +0000 (12:54 +0200)]
Revert workaround for desktop toplevel item in the tree view

Since the toplevel item issue is fixed now, this is no longer necessary
and can be reverted.

4 years agoAlways select the proper toplevel item in the thunar tree view
Harald Judt [Sat, 9 May 2015 10:40:57 +0000 (12:40 +0200)]
Always select the proper toplevel item in the thunar tree view

When the user clicks on e.g. "Desktop" in the treeview, the treeview
will expand the tree and set the cursor on home/Desktop instead on the
proper toplevel item (assuming the Desktop folder resides in the user's
home directory of course). This is very bad for user experience.

To fix this, this commit makes the treeview

a) use the cursor if set to limit the search to below the current
   toplevel item
b) select the proper toplevel item to expand to the descendant in the
   following order:
   1) any mounted device or network resource
   2) the user's desktop directory
   3) the user's home directory
   4) the root filesystem

4 years agoUnescape URI in history error message
Harald Judt [Thu, 7 May 2015 19:06:07 +0000 (21:06 +0200)]
Unescape URI in history error message

4 years agoRemove unmounted files from history when going back or forward
Harald Judt [Thu, 7 May 2015 18:57:23 +0000 (20:57 +0200)]
Remove unmounted files from history when going back or forward

When trying to go back or forward in history, and the target location
has been unmounted, remove the entry from the history.

4 years agoI18n: Update translation fr (100%).
Yannick Le Guen [Sat, 9 May 2015 10:30:18 +0000 (12:30 +0200)]
I18n: Update translation fr (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoI18n: Update translation gl (100%).
Dani MF [Wed, 6 May 2015 10:30:37 +0000 (12:30 +0200)]
I18n: Update translation gl (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoI18n: Update translation eu (97%).
Piarres Beobide [Wed, 6 May 2015 10:30:37 +0000 (12:30 +0200)]
I18n: Update translation eu (97%).

722 translated messages, 16 untranslated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoPost release tag bump
Harald Judt [Tue, 5 May 2015 17:47:15 +0000 (19:47 +0200)]
Post release tag bump

4 years agoUpdates for release thunar-1.6.8
Harald Judt [Tue, 5 May 2015 17:35:32 +0000 (19:35 +0200)]
Updates for release

4 years agoWatch for CHANGES_DONE_HINT instead of CHANGED and ATTRIBUTE_CHANGED (bug #8377)
Harald Judt [Sat, 2 May 2015 15:40:22 +0000 (17:40 +0200)]
Watch for CHANGES_DONE_HINT instead of CHANGED and ATTRIBUTE_CHANGED (bug #8377)

https://developer.gnome.org/gio/unstable/GFileMonitor.html#GFileMonitorEvent:
G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT:
"A hint that this was probably the last change in a set of changes."

Reloading file information can be costly, so it may be wise to only do this
after a set of changes has been performed, which is not emitted as often
as the CHANGED and ATTRIBUTE_CHANGED hint.

The G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT will always be emitted after
G_FILE_MONITOR_EVENT_CHANGED and G_FILE_MONITOR_EVENT_ATTRIBUTE_CHANGED,
so wait for it with the reload.

Possible risks: On some (especially remote?) file systems, the EVENT_CHANGED
and ATTRIBUTE_CHANGED might take a while to be processed, resulting in the
reload happening later. But then, why would it be faster to reload the
file before all these changes have been done?

4 years agoI18n: Update translation gl (100%).
Dani MF [Tue, 5 May 2015 16:30:18 +0000 (18:30 +0200)]
I18n: Update translation gl (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoI18n: Update translation gl (99%).
Dani MF [Tue, 5 May 2015 10:30:19 +0000 (12:30 +0200)]
I18n: Update translation gl (99%).

734 translated messages, 4 untranslated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoShortcut view: Fix "selection in selection" graphical bug when renaming shortcut
Harald Judt [Mon, 4 May 2015 13:20:47 +0000 (15:20 +0200)]
Shortcut view: Fix "selection in selection" graphical bug when renaming shortcut

This partly reverts the previous commit which was not correct,
and fixes the real problem which can be seen when cancelling editing.

4 years agoFix broken shortcut renaming (bug #11885)
Harald Judt [Mon, 4 May 2015 09:46:31 +0000 (11:46 +0200)]
Fix broken shortcut renaming (bug #11885)

This fixes the shortcut renaming feature broken by f60acf89a1321be
"Allow <ctrl> + middle click in shortcut and treeview panes" and
also removes the weird-looking "selection in selection" which maybe can
only be noticed by some themes, but is reproducible with Greybird.

4 years agoUnescape URIs in the shortcut view (bug #10831)
Harald Judt [Mon, 4 May 2015 05:31:49 +0000 (07:31 +0200)]
Unescape URIs in the shortcut view (bug #10831)

Show spaces in the path names instead of "%20".

4 years agoFix compiler warning because of missing curly braces
Harald Judt [Mon, 4 May 2015 05:40:38 +0000 (07:40 +0200)]
Fix compiler warning because of missing curly braces

4 years agoFix compilation error because of wrong variable name
Harald Judt [Mon, 4 May 2015 05:38:59 +0000 (07:38 +0200)]
Fix compilation error because of wrong variable name

4 years agoI18n: Update translation de (100%).
Harald Judt [Sun, 3 May 2015 22:30:18 +0000 (00:30 +0200)]
I18n: Update translation de (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoFix unescaping of local paths in path entry (bug #8190)
Harald Judt [Sun, 3 May 2015 16:31:14 +0000 (18:31 +0200)]
Fix unescaping of local paths in path entry (bug #8190)

Unfortunately, the previous commit did not work correctly for local paths
in all cases. This commit fixes this by distinguishing between local paths
and URIs.

4 years agoFix escaping and unescaping URI in path entry (bug #8910)
Harald Judt [Sun, 3 May 2015 15:12:53 +0000 (17:12 +0200)]
Fix escaping and unescaping URI in path entry (bug #8910)

Escaping the URI in thunar_path_entry_changed is necessary for correctly
loading the corresponding ThunarFile for the GFile.

This solves bug #8910 where the problem stems from URI unescaping,
resulting in the unescaped text being NULL. This is handled by the
second part of the patch, which falls back to the unescaped text.

Without this commit, directories containing characters like "%", e.g
"test%folder", can be opened but

1) on remote locations the icon in the toolbar location selector will
   show an error indicating there is something wrong,
2) while on local filesystems only the parent path will be shown in
   the path entry.

4 years agoLet the tree view keep the focus when clicking on an item (bug #11863)
Harald Judt [Sat, 2 May 2015 18:20:12 +0000 (20:20 +0200)]
Let the tree view keep the focus when clicking on an item (bug #11863)

When clicking on a tree view item, the main view will open it and thus
grab the focus. This focus change may be a bit unexpected to the user,
but trivial to fix, so make the tree view keep the focus after such a
button click.

4 years agoFix switching to the 10th tab via <alt>-<0> keyboard shortcut
Harald Judt [Fri, 1 May 2015 17:57:18 +0000 (19:57 +0200)]
Fix switching to the 10th tab via <alt>-<0> keyboard shortcut

4 years agoFix removal of a directory wrongly affecting the current tab (bug #10981)
Harald Judt [Sat, 2 May 2015 12:06:01 +0000 (14:06 +0200)]
Fix removal of a directory wrongly affecting the current tab (bug #10981)

This fixes the following bug:

1) Create two directories (a and b).
2) Open them in tabs in a thunar window.
3) Switch to the tab currently showing a and delete b from a terminal.

Expected behaviour:
Inactive tab showing b will switch to the parent directory.
Active tab showing a will be unaffected.

Actual behaviour:
Inactive tab showing b will switch to the parent directory.
Active tab showing a will not change the directory.

4 years agoKeep the scroll position when restoring the file selection
Harald Judt [Fri, 1 May 2015 12:10:00 +0000 (14:10 +0200)]
Keep the scroll position when restoring the file selection

Instead of trying to keep the selected files in view when rows get
reordered, leave the scroll position unchanged. Otherwise, the user
might not be able to select files easily.

By setting fix lower/upper limits for the scrolled window alignments
we make sure that the view does not flicker because the position
would change twice.

4 years agoRestore selection only when rows-reordered signal is received (bug #11855)
Harald Judt [Fri, 1 May 2015 10:37:31 +0000 (12:37 +0200)]
Restore selection only when rows-reordered signal is received (bug #11855)

Commit 4d19f45feb198b "Restore selection on row changes too (bug #9886)"
forced the file selection to be restored on row changes, which has the
negative side effect that the view will also scroll to the selected
file(s) whenever such a change happens, e.g. when thumbnailing finishes.

The better fix is to listen to the rows-reordered signal which no view
listens to at the moment. This commit implements this.

4 years agoFor folders copied always append "copy #" to the end of their names (bug #11862)
Harald Judt [Fri, 1 May 2015 07:25:03 +0000 (09:25 +0200)]
For folders copied always append "copy #" to the end of their names (bug #11862)

Files usually have extensions, but most folders do not. This is also the
way the renamer dialog treats filenames, so the behaviour should be the
same.

4 years agoUpdate F5 binding for new ThunarWindow::reload signal
Evangelos Foutras [Mon, 27 Apr 2015 08:55:12 +0000 (11:55 +0300)]
Update F5 binding for new ThunarWindow::reload signal

In commit b839b29d6dfa57aab9c3cec97eca7624a483a45e (Extend reload
functions to allow a full reload) an extra parameter was added to
reload functions that specifies whether file information should be
reloaded as well.

4 years agoDo not perform the complete folder reload in idle (bug #11849)
Harald Judt [Thu, 23 Apr 2015 19:41:45 +0000 (21:41 +0200)]
Do not perform the complete folder reload in idle (bug #11849)

This can cause an infinite loop as described in the bug report.

4 years agoI18n: Update translation lt (100%).
Anonymous [Wed, 22 Apr 2015 22:30:30 +0000 (00:30 +0200)]
I18n: Update translation lt (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoCoverity CID 60623: Unused value
Harald Judt [Wed, 22 Apr 2015 11:38:51 +0000 (13:38 +0200)]
Coverity CID 60623: Unused value

CID 60623 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value from event->x to path_entry->drag_x here,
but that stored value is overwritten before it can be used.

...

value_overwrite: Overwriting previous write to path_entry->drag_x with
value from event->y.

4 years agoCoverity CID 60621: Missing return statement
Harald Judt [Wed, 22 Apr 2015 11:06:37 +0000 (13:06 +0200)]
Coverity CID 60621: Missing return statement

CID 60621 (#1 of 1): Missing return statement (MISSING_RETURN)
5. missing_return: Arriving at the end of a function without
returning a value.

4 years agoCoverity CID 60620: Explicit null dereferenced
Harald Judt [Wed, 22 Apr 2015 11:00:19 +0000 (13:00 +0200)]
Coverity CID 60620: Explicit null dereferenced

CID 60620 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
17. var_deref_model: Passing null pointer file_list to
thunar_application_unlink_files, which dereferences it.

4 years agoCoverity CID 60619: Explicit null dereferenced
Harald Judt [Wed, 22 Apr 2015 10:56:39 +0000 (12:56 +0200)]
Coverity CID 60619: Explicit null dereferenced

CID 60619 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
20. var_deref_op: Dereferencing null pointer left_button.

4 years agoCoverity CID 60617: Unchecked return value
Harald Judt [Wed, 22 Apr 2015 10:47:59 +0000 (12:47 +0200)]
Coverity CID 60617: Unchecked return value

CID 60617 (#1 of 1): Unchecked return value (CHECKED_RETURN)
1. check_return: Calling gtk_tree_model_get_iter_first without
checking return value (as is done elsewhere 4 out of 5 times).

4 years agoRemove unused variable in thunar_standard_view_set_history
Harald Judt [Tue, 21 Apr 2015 09:54:59 +0000 (11:54 +0200)]
Remove unused variable in thunar_standard_view_set_history

Fix gcc warning.

4 years agoRemove startup notification dependencies (bug #11837)
Harald Judt [Tue, 21 Apr 2015 09:53:02 +0000 (11:53 +0200)]
Remove startup notification dependencies (bug #11837)

This functionality is now provided by libxfce4ui, see commit
8990efaf5a "Use the spawn code from libxfce4ui."

4 years agoPost release tag bump
Harald Judt [Mon, 20 Apr 2015 14:33:10 +0000 (16:33 +0200)]
Post release tag bump

4 years agoUpdates for release thunar-1.6.7
Harald Judt [Mon, 20 Apr 2015 14:01:13 +0000 (16:01 +0200)]
Updates for release

4 years agoImprove drag & drop and selecting in the details view (bug #11605)
Harald Judt [Tue, 7 Apr 2015 17:27:12 +0000 (19:27 +0200)]
Improve drag & drop and selecting in the details view (bug #11605)

When using the left mouse button, clicking on the first column of an item
will select it or initiate dragging, but rubber banding is deactivated.
For the other columns, only rubber banding will be possible and dragging
be disabled.

When using the right mouse button, clicking on the first column of an
item will always select it and pop up the context menu of the item.
Clicking on another column of an unselected item will unselect all
items and show the menu of the folder, while clicking on another
column of a selected item will show the context menu for that item
(or those items).

An extensive explanation has been added to the thunar docs in the wiki:
http://docs.xfce.org/xfce/thunar/working-with-files-and-folders

4 years agoMerge branch 'fix-bug-11008'
Harald Judt [Sat, 18 Apr 2015 12:17:39 +0000 (14:17 +0200)]
Merge branch 'fix-bug-11008'

4 years agoFix comments (again)
Harald Judt [Sat, 18 Apr 2015 12:15:07 +0000 (14:15 +0200)]
Fix comments (again)

4 years agoLet row changes accumulate a bit before restoring selection
Harald Judt [Sat, 18 Apr 2015 09:32:02 +0000 (11:32 +0200)]
Let row changes accumulate a bit before restoring selection

With the changes introduced in 4d19f45feb198 "Restore selection on row
changes too (bug #9886)", slight flicker can be noticed when navigating
with forward/back actions. This is because row-changed events sometimes
cause a restore of the selection multiple times.

To solve this, this commit adds a short timeout for restoring the
selection in a similar way as for the status bar text updates.

4 years agoImplement reloading file information on manual reload
Harald Judt [Fri, 17 Apr 2015 09:47:37 +0000 (11:47 +0200)]
Implement reloading file information on manual reload

4 years agoExtend reload functions to allow a full reload
Harald Judt [Fri, 17 Apr 2015 09:29:34 +0000 (11:29 +0200)]
Extend reload functions to allow a full reload

Usually a folder is reloaded automatically on file changes, and the user
shouldn't have to do it manually. However, when the user *wants* to do
it manually, everything is expected to be reloaded, even the files in
cache, because their info may have changed. At the moment, this does not
happen, and there can be various issues with cached file info, so extension
is a first step to allow the user to decide to reload everything in the
folder.

4 years agoCheck in thunar-marshal with new _thunar_marshal_BOOLEAN__BOOLEAN
Harald Judt [Fri, 17 Apr 2015 10:59:09 +0000 (12:59 +0200)]
Check in thunar-marshal with new _thunar_marshal_BOOLEAN__BOOLEAN

Remove thunar-marshal from .gitignore, this needs to be tracked.

4 years agoReload files changed by jobs in an idle loop (bug #11008)
Harald Judt [Thu, 9 Apr 2015 11:14:19 +0000 (13:14 +0200)]
Reload files changed by jobs in an idle loop (bug #11008)

If a file is in the cache, schedule a reload of the file when idle.
This way file information gets updated properly when necessary and
without any crashes.

4 years agoRefactor code for moving thumbnail cache file on renames/moves
Harald Judt [Wed, 25 Mar 2015 16:42:45 +0000 (17:42 +0100)]
Refactor code for moving thumbnail cache file on renames/moves

4 years agoRework thunar_file_monitor to properly register moved files
Harald Judt [Wed, 25 Mar 2015 16:34:07 +0000 (17:34 +0100)]
Rework thunar_file_monitor to properly register moved files

4 years agoAdd function to reload parent file of a file
Harald Judt [Wed, 25 Mar 2015 14:19:56 +0000 (15:19 +0100)]
Add function to reload parent file of a file

4 years agoFix updating file info for moved files (bug #11008)
Harald Judt [Mon, 16 Mar 2015 18:29:48 +0000 (19:29 +0100)]
Fix updating file info for moved files (bug #11008)

When a file has been moved, it will trigger a G_FILE_MONITOR_EVENT_MOVED
in thunar-folder.c, with the target file saved in other_file. While we
reload the folder, that only fetches the info for the target file from
the file info cache, which still contains the information of the replaced
file. So issue a reload of the target file to update the file information
properly, and also a reload of the folder containing the target file if
it is not the same as the folder of the source file.

4 years agoRevert "Refresh file info after getting it from cache (bug #11008)"
Harald Judt [Mon, 16 Mar 2015 18:36:23 +0000 (19:36 +0100)]
Revert "Refresh file info after getting it from cache (bug #11008)"

This reverts commit cc8d1331e305f2af5842607d885eb96608b8fce7,
which proved to cause crashes due to threading issues.

4 years agoFix comments
Harald Judt [Thu, 16 Apr 2015 20:23:23 +0000 (22:23 +0200)]
Fix comments

4 years agoI18n: Update translation sv (99%).
Fredrik Nyqvist [Mon, 13 Apr 2015 22:30:27 +0000 (00:30 +0200)]
I18n: Update translation sv (99%).

735 translated messages, 3 untranslated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoI18n: Update translation de (100%).
Harald Judt [Mon, 13 Apr 2015 16:30:19 +0000 (18:30 +0200)]
I18n: Update translation de (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoUpdate the location bar after reload (bug #10518)
Harald Judt [Mon, 13 Apr 2015 15:36:24 +0000 (17:36 +0200)]
Update the location bar after reload (bug #10518)

Show the correct path in the location bar after the user has
reloaded the folder manually from the menu or from the button
in the location bar.

This improves UI feedback and is also the standard behaviour
in other applications.

4 years agoFix updating custom actions (bug #11749)
Harald Judt [Sat, 11 Apr 2015 15:49:53 +0000 (17:49 +0200)]
Fix updating custom actions (bug #11749)

https://developer.gnome.org/gtk3/stable/GtkUIManager.html#gtk-ui-manager-insert-action-group

"Inserts an action group into the list of action groups associated with manager.
 Actions in earlier groups hide actions with the same name in later groups.
 If pos is larger than the number of action groups in manager, or negative,
 action_group will be inserted at the end of the internal list."

Always keep the window actions (group "ThunarActions") at the top of the
internal list of the GTK UI manager, so that they appear earlier. This
way, the shortcuts will not be lost, and the custom actions for the
context menu created by ThunarStandardView will work properly nonetheless.

Also update the UI manager immediately after inserting the action group,
otherwise GClosure warnings will spawn on stdout:
"g_closure_add_invalidate_notifier: assertion 'closure->n_inotifiers <
 CLOSURE_MAX_N_INOTIFIERS' failed
 unable to remove uninstalled invalidation notifier"

4 years agoUpdate rows on changes of case-sensitive and folders-first settings
Harald Judt [Sat, 11 Apr 2015 10:17:32 +0000 (12:17 +0200)]
Update rows on changes of case-sensitive and folders-first settings

This is analogous to 02baccc0858a37a3bfa6d027cf05f32578ea0106.

4 years agoFix typos and grammar mistakes in a few comments
Harald Judt [Sat, 28 Mar 2015 11:29:47 +0000 (12:29 +0100)]
Fix typos and grammar mistakes in a few comments

4 years agoMake new windows inherit the history of the origin view (bug #5538)
Harald Judt [Wed, 8 Apr 2015 20:12:06 +0000 (22:12 +0200)]
Make new windows inherit the history of the origin view (bug #5538)

4 years agoMake new tabs inherit the history of the origin view (bug #5538)
Harald Judt [Wed, 8 Apr 2015 18:04:17 +0000 (20:04 +0200)]
Make new tabs inherit the history of the origin view (bug #5538)

4 years agoKeep the history across view changes (bug #10171)
Harald Judt [Wed, 8 Apr 2015 17:56:39 +0000 (19:56 +0200)]
Keep the history across view changes (bug #10171)

4 years agoImplement functions for copying the history of a view
Harald Judt [Wed, 8 Apr 2015 15:04:15 +0000 (17:04 +0200)]
Implement functions for copying the history of a view

These functions are needed for keeping the history when a view changes,
or when a new window or tab is opened that should inherit the history
of the origin view.

4 years agoI18n: Update translation en_AU (100%).
Michael Findlay [Thu, 9 Apr 2015 04:30:18 +0000 (06:30 +0200)]
I18n: Update translation en_AU (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoI18n: Update translation lt (100%).
Anonymous [Wed, 8 Apr 2015 22:30:35 +0000 (00:30 +0200)]
I18n: Update translation lt (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoI18n: Update translation pl (100%).
Piotr Sokół [Mon, 6 Apr 2015 16:30:18 +0000 (18:30 +0200)]
I18n: Update translation pl (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoI18n: Update translation fr (100%).
Urien Desterres [Sat, 4 Apr 2015 10:30:18 +0000 (12:30 +0200)]
I18n: Update translation fr (100%).

738 translated messages.

Transifex (https://www.transifex.com/projects/p/xfce/).

4 years agoRename tsv_restore_selection to tsv_select_after_row_deleted
Harald Judt [Wed, 1 Apr 2015 14:54:57 +0000 (16:54 +0200)]
Rename tsv_restore_selection to tsv_select_after_row_deleted

To avoid confusion with the many select functions rename this to
thunar_standard_view_select_after_row_deleted, which is also the only
scenario this is used in.

4 years agoRedraw the details view on row changes
Harald Judt [Tue, 31 Mar 2015 21:32:17 +0000 (23:32 +0200)]
Redraw the details view on row changes

This cures some update problems that can be observed when setting
e.g. date modified as sort column and some script changes various
files in the background. Example script:

while true; do
  for f in l m n o a b c d e f g h i j k; do
    touch "$f"
    sleep 0.5
  done
done

4 years agoRestore selection on row changes too (bug #9886)
Harald Judt [Tue, 31 Mar 2015 20:05:22 +0000 (22:05 +0200)]
Restore selection on row changes too (bug #9886)

4 years agoI18n: Update translation hr (99%).
Ivica Kolić [Thu, 2 Apr 2015 10:30:18 +0000 (12:30 +0200)]
I18n: Update translation hr (99%).

737 translated messages, 1 untranslated message.

Transifex (https://www.transifex.com/projects/p/xfce/).